[libcxx-commits] [PATCH] D116278: [libc++][ranges] Add ranges::in_in_result

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a reviewer: ldionne.
Quuxplusone added a comment.

LGTM % nitpicks.



================
Comment at: libcxx/include/CMakeLists.txt:29-31
   __algorithm/includes.h
+  __algorithm/in_in_result.h
   __algorithm/inplace_merge.h
----------------
Swap lines 30 and 31: `inp` < `in_` < `is_` seems good to me.


================
Comment at: libcxx/include/__algorithm/in_in_result.h:13-14
+
+#include <__config>
+#include <__concepts/convertible_to.h>
+#include <__utility/move.h>
----------------
Swap these two lines. (One of these days I'll make `graph_header_deps.py` just check for a-z order.)


================
Comment at: libcxx/include/algorithm:20
 {
+namespace ranges {
+  template <class I1, class I2>
----------------
This namespace formatting is going to be weird no matter what we do, but I suggest just adding a blank line between lines 19 and 20.


================
Comment at: libcxx/include/algorithm:695
 #include <__algorithm/is_heap.h>
+#include <__algorithm/in_in_result.h>
 #include <__algorithm/is_heap_until.h>
----------------
Swap with line 694: `inp` < `in_` < `is_` seems good to me.


================
Comment at: libcxx/test/std/algorithms/algorithms.results/in_in_result.pass.cpp:14
+
+#include "__algorithm/in_in_result.h"
+#include <algorithm>
----------------
Remove this `#include` of a private header. (The Modules build should be unhappy with this, right?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116278/new/

https://reviews.llvm.org/D116278