[libcxx-commits] [PATCH] D116295: [libc++] Add missing templated version of `std::lerp`

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 6 10:09:39 PST 2022


Quuxplusone updated this revision to Diff 397926.
Quuxplusone added a comment.

Flatten `c.math.lerp/c.math.lerp.pass.cpp` to `lerp.pass.cpp`, to match `abs.pass.cpp`.
Add "See also" comments to both `test_abs` and `test_lerp`.
Reindent `test_abs` for consistency with the rest of these functions.

If CI is green, imma land this.  There may be room for more thorough testing in `lerp.pass.cpp`, but at least `test_lerp()` does smoke-test the new overload (with both `assert` and `static_assert`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116295/new/

https://reviews.llvm.org/D116295

Files:
  libcxx/include/cmath
  libcxx/test/std/numerics/c.math/c.math.lerp/c.math.lerp.pass.cpp
  libcxx/test/std/numerics/c.math/cmath.pass.cpp
  libcxx/test/std/numerics/c.math/lerp.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116295.397926.patch
Type: text/x-patch
Size: 7189 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220106/66bf8209/attachment.bin>


More information about the libcxx-commits mailing list