[libcxx-commits] [PATCH] D116691: [libc++] Add Status page for P2321R2 (Zip)

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 6 09:15:51 PST 2022


Mordante added a comment.

Thanks for working on this!



================
Comment at: libcxx/docs/Status/ZipProjects.csv:6
+| `[pairs.pair] <https://wg21.link/pairs.pair>`_, "[pair] constructor, assignment and swap overloads", None, Nikolas Klauser, |Not Started|
+"| `[memory.syn] <https://wg21.link/memory.syn>`_
+| `[allocator.uses.construction] <https://wg21.link/allocator.uses.construction>`_", "[pair] uses_allocator_construction_args overloads", None, Unassigned, |Not Started|
----------------
This line looks odd.


================
Comment at: libcxx/docs/Status/ZipProjects.csv:9
+| `[vector.bool] <https://wg21.link/vector.bool>`_, "[vector<bool>::reference] add const operator= overload", None, Nikolas Klauser, |Not Started|
+| `[iterator.concept.winc] <https://wg21.link/iterator.concept.winc>`_, "Update weakly_comparable", None, Unassigned, |Not Started|
+| `[range.zip] <https://wg21.link/ranges.syn>`_, "zip_view", "| `zip_view::iterator`
----------------
I miss [ranges.syn]. I like to see it since it's the only place with the `enable_borrowed_range`.


================
Comment at: libcxx/docs/Status/ZipProjects.csv:11
+| `[range.zip] <https://wg21.link/ranges.syn>`_, "zip_view", "| `zip_view::iterator`
+| `zip_view::sentinel`", Unassigned, |Not Started|
+| `[range.zip.iterator] <https://wg21.link/range.zip.transform>`_, "zip_view::iterator", None, Unassigned, |Not Started|
----------------
Should these two lines be one line? (I see similar issues on lines 14-15, 18-19, 22-23.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116691/new/

https://reviews.llvm.org/D116691



More information about the libcxx-commits mailing list