[libcxx-commits] [PATCH] D116712: [libc++] [test] Remove `UNSUPPORTED: stdlib=msvc` from lock.pass.cpp

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 5 16:34:23 PST 2022


Quuxplusone created this revision.
Quuxplusone added reviewers: libc++, CaseyCarter, ldionne, mstorsjo, philnik.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

@CaseyCarter says, "We run std/thread/thread.mutex/thread.lock.algorithm/lock.pass.cpp on every CI and it works fine with MSVC STL. I'm guessing this annotation predates @BillyONeal's rewrite of std::lock in 2017-ish."


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116712

Files:
  libcxx/test/std/thread/thread.mutex/thread.lock.algorithm/lock.pass.cpp


Index: libcxx/test/std/thread/thread.mutex/thread.lock.algorithm/lock.pass.cpp
===================================================================
--- libcxx/test/std/thread/thread.mutex/thread.lock.algorithm/lock.pass.cpp
+++ libcxx/test/std/thread/thread.mutex/thread.lock.algorithm/lock.pass.cpp
@@ -8,10 +8,8 @@
 //
 // UNSUPPORTED: libcpp-has-no-threads
 
-// This test hangs forever when built against libstdc++ and MSVC. In order to allow
-// validation of the test suite against other STLs we have to mark it
-// unsupported.
-// UNSUPPORTED: stdlib=libstdc++, stdlib=msvc
+// This test hangs forever when built against libstdc++ (Oct 2016)
+// UNSUPPORTED: stdlib=libstdc++
 
 // <mutex>
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116712.397741.patch
Type: text/x-patch
Size: 699 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220106/abea03ec/attachment-0001.bin>


More information about the libcxx-commits mailing list