[libcxx-commits] [PATCH] D115977: [libc++] Implement P1425R4 (Iterator pair constructors for std::stack and std::queue)

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 5 15:39:31 PST 2022


jloser added a comment.

I haven't finished reviewing this in full yet, but do we need to use `enable_if_t` instead of concepts/`requires` since this is C++23 code? I.e. is our requirement of using older `AppleClang` version in C++23 mode an issue with this (and therefore we must use `enable_if_t` still)? The consistency argument is fine - I'm asking purely from a technical standpoint.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115977/new/

https://reviews.llvm.org/D115977



More information about the libcxx-commits mailing list