[libcxx-commits] [PATCH] D116689: [libunwind][libcxxabi] Use object libraries in the build

[Saleem Abdulrasool via Phabricator via libcxx-commits]

compnerd added a comment.

Using the `TARGET_OBJECTS:` generator seems better.  However, I also have concerns over using the shared library objects.  At least for Windows, reuse of the objects meant for a shared object is not really correct.  This is non-portable at best, and incorrect at worse.  I would rather that we just introduce a proper target that we use can for embedding into another library (which may or may not expose its interfaces from the library that integrates it).



================
Comment at: libcxx/src/CMakeLists.txt:233
+    elseif (LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_SHARED_LIBRARY AND (TARGET unwind_shared_objects OR HAVE_LIBUNWIND))
+      target_link_libraries(cxx_shared PUBLIC unwind_shared_objects)
     else()
----------------
Why not use `TARGET_OBJECTS:unwind>` instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116689/new/

https://reviews.llvm.org/D116689