[libcxx-commits] [PATCH] D116472: Allow overriding path to shared CMake utilities

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jan 1 01:13:37 PST 2022


mstorsjo added a comment.

In D116472#3215562 <https://reviews.llvm.org/D116472#3215562>, @Ericson2314 wrote:

> @mstorsjo I hope this fixes the issue you had in https://reviews.llvm.org/D115568#3215445. I just whipped this up coding blind. If you could test it to ensure it solves your issue, that would be much appreciated!

Thanks!

We shouldn’t need this for the runtimes; they have their own story for how they’re built (which is complicated enough in other ways), and I don’t think anyone is symlinking then around.

Secondly, we’d need to set this in llvm/CMakeLists.txt too, to make it work automatically.

I can try to fix the patch and commandeer it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116472/new/

https://reviews.llvm.org/D116472



More information about the libcxx-commits mailing list