[libcxx-commits] [PATCH] D116495: [libc++][format] Improve an exception message.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 4 09:29:28 PST 2022


Mordante added a comment.

This as a generic message error message and a leading zero is one of the possible errors. As you can see in the tests it also rejects `{9a`, `{9:`. I don't think it's useful to add an extra code path to add more details for the exact error. There's also no specific error for `{1` at the end of input. Do you think it's useful to show the expected format? Something along the lines of "Arg-id doesn't match {(0|[1-9][0-9]*)}".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116495/new/

https://reviews.llvm.org/D116495



More information about the libcxx-commits mailing list