[libcxx-commits] [PATCH] D116569: [libc++] [ranges] Add namespace __cpo to ranges::{advance, next, prev}.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const requested changes to this revision.
var-const added a comment.
This revision now requires changes to proceed.

The main intention of the patch very much LGTM, but some formatting nitpicks. Please let me know if I'm missing something.



================
Comment at: libcxx/include/__iterator/advance.h:74
+namespace __advance {
+  struct __fn final : private __function_like {
+  private:
----------------
Formatting nit: I think namespaces [aren't supposed to](https://llvm.org/docs/CodingStandards.html#namespace-indentation) introduce a new level of indentation.


================
Comment at: libcxx/include/__iterator/advance.h:75
+  struct __fn final : private __function_like {
+  private:
+    template <class _Tp>
----------------
It looks like it's using tabs for indentation now, is this intentional?


================
Comment at: libcxx/include/__iterator/advance.h:192
+inline namespace __cpo {
+  inline constexpr auto advance = __advance::__fn(__function_like::__tag());
+} // namespace __cpo
----------------
Same nit here: I think this variable declaration shouldn't be indented.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116569/new/

https://reviews.llvm.org/D116569