[libcxx-commits] [PATCH] D116570: [libc++] Eliminate the `__function_like` helper.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 3 18:05:39 PST 2022


Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, var-const, libc++.
Quuxplusone added a project: libc++.
Herald added a subscriber: mgorny.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

As prefigured in the comments on D115315 <https://reviews.llvm.org/D115315>.

This gives us one unified style for all niebloids, and also simplifies the modulemap: it's important that we do this simplification before the modulemap gets completely out of hand.

(This was split out of D116384 <https://reviews.llvm.org/D116384>. @ldionne, this is the PR where we can argue about whether `__function_like` provides a benefit to justify its IMO-high maintenance cost.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116570

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__function_like.h
  libcxx/include/__iterator/advance.h
  libcxx/include/__iterator/next.h
  libcxx/include/__iterator/prev.h
  libcxx/include/__memory/ranges_uninitialized_algorithms.h
  libcxx/include/module.modulemap
  libcxx/test/libcxx/diagnostics/detail.headers/function_like.h.module.verify.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116570.397169.patch
Type: text/x-patch
Size: 15518 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220104/e4ae4891/attachment-0001.bin>


More information about the libcxx-commits mailing list