[libcxx-commits] [PATCH] D116433: [libc++] [P0887] Add newest feature-test macros; mark `type_identity` as implemented.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:74
+    "unimplemented": True,
   }, {
     "name": "__cpp_lib_allocator_traits_is_always_equal",
----------------
Quuxplusone wrote:
> Mordante wrote:
> > Please update the patch title and description to match the changed scope.
> The title is currently "[libc++] [P0887] Add newest feature-test macros; mark `type_identity` as implemented." What did you have in mind?
The title got me on the wrong foot due to the wording. It adds more macros than the one in P0887 and only marks P0887 as complete. So it seems a bit confusing, reading it again it's not really wrong. (Maybe just drop P0887 from the title.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116433/new/

https://reviews.llvm.org/D116433