[libcxx-commits] [PATCH] D116489: [libc++] [API BREAK] Change `fs::path::iterator::iterator_category` to `input_iterator_tag`.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I am fine with this, but it needs a release note under API changes. Also, it's technically possible for this to be an ABI break (if someone had `path::iterator::reference` in their ABI). However, if they do, it would cause a mangling issue so it would be caught at compile-time, which makes this acceptable to me ABI-wise.

Before I really give this a ship-it, let me run it on a large code base. We might discover some interesting fallout.



================
Comment at: libcxx/test/std/input.output/filesystems/class.path/path.itr/iterator.pass.cpp:35
+#if TEST_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_RANGES)
+  assert(std::bidirectional_iterator<It>);
+#endif
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116489/new/

https://reviews.llvm.org/D116489