[libcxx-commits] [PATCH] D116234: [libc++][NFC] Reformat <__filesystem/operations.h>

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 3 07:09:42 PST 2022


ldionne accepted this revision.
ldionne added a comment.

FWIW, I have no strong preference here. I think the code was readable before and is readable after. I think this is a follow up on a suggestion I made in an earlier modularization patch where I suggested aligning stuff would highlight that they are all forwarding to functions inside the dylib. That's the main benefit I see with this patch.

LGTM, but please rename to `_LIBCPP_HIDE_FROM_ABI` in another patch (or this one, IDC).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116234/new/

https://reviews.llvm.org/D116234



More information about the libcxx-commits mailing list