[libcxx-commits] [PATCH] D116239: [libc++] [ranges] ADL-proof the [range.access] CPOs.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Re @Quuxplusone

> I still don't understand why the well-formedness check of `t.begin()` triggers instantiation of `Holder<Incomplete>` when t is a pointer ( https://godbolt.org/z/Tfb3vTrvf ); I should ask around about that.

Right, that's the first thing that I think about when I see this PR. This looks like a Clang bug to me, is that possible? I don't understand why `t.begin()` could ever trigger ADL, and hence why this fix is necessary from the library side at all. Instead, I would expect that we fix Clang and then add the tests.

Of course, I'm probably wrong, but it would be worth understanding this instead of blindly "fixing" the library.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116239/new/

https://reviews.llvm.org/D116239