[libcxx-commits] [PATCH] D116486: [libc++][NFC] Use _LIBCPP_DEBUG_ASSERT in <__hash_table>

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Jan 2 08:39:11 PST 2022


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: libcxx/include/__hash_table:2488
+                         "unordered container erase(iterator) called with a non-dereferenceable iterator");
 #if _LIBCPP_DEBUG_LEVEL == 2
     iterator __r(__np, this);
----------------
In this case I have a slight preference to keep the original code, since it doesn't remove the `#if`. But I won't object against the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116486/new/

https://reviews.llvm.org/D116486



More information about the libcxx-commits mailing list