[libcxx-commits] [PATCH] D116346: [libc++] Fix __wrap_iter copy-assignment in constexpr contexts

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM with one minor suggestion, but please wait for the CI to complete.



================
Comment at: libcxx/test/std/strings/basic.string/string.iterators/iterators.pass.cpp:82
+    test();
+#if 0
+    static_assert(test());
----------------
Can we make this test dependent on the implementation status of the `constexpr` `std::string` in a similar fashion as testing for `char8_t`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116346/new/

https://reviews.llvm.org/D116346