[libcxx-commits] [PATCH] D116346: [libc++] Fix __wrap_iter copy-assignment in constexpr contexts

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/test/std/strings/basic.string/string.iterators/iterators.pass.cpp:58
+        i2 = i1;
+        assert ( i1 == i2 );
+    }
----------------
Quuxplusone wrote:
> Before line 57, let's `assert ( i1 != i2 );`
> Notice that this test won't work until std::string becomes constexpr, which is why it's `#if`'ed out on line 82 below.
> ...Waitaminute. Since we're still waiting for CI to come back, anyway, could you please investigate why this godbolt (using `span` instead of `string` to get its `__wrap_iter`s) does //not// reproduce the bug? I think it //should// fail, but I must be missing something.
> https://godbolt.org/z/4aGTK79b5
> 
You forgot to add `-D_LIBCPP_DEBUG=1` to your command line args.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116346/new/

https://reviews.llvm.org/D116346