[libcxx-commits] [PATCH] D120633: [libc++] Better handling for zero-sized types

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone updated this revision to Diff 411915.
Quuxplusone marked an inline comment as done.
Quuxplusone added a comment.

Address review comments. `UNSUPPORTED: msvc`.

Restore the check for `is_void` too. Geez, these super-helpful compilers just let us `delete` anything, in a system header! I wonder what the generated code actually does at runtime...

https://reviews.llvm.org/harbormaster/unit/view/2823801/ is due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104568 so `UNSUPPORTED: gcc-11` for this test (it's not super important to test, and we can reenable the test when GCC fixes their ICE)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120633/new/

https://reviews.llvm.org/D120633

Files:
  libcxx/include/__memory/unique_ptr.h
  libcxx/include/__ranges/access.h
  libcxx/test/std/ranges/range.access/begin.sizezero.pass.cpp
  libcxx/test/std/ranges/range.access/end.sizezero.pass.cpp
  libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.create/make_unique.sizezero.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120633.411915.patch
Type: text/x-patch
Size: 6229 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220228/eee5433a/attachment.bin>