[libcxx-commits] [PATCH] D117357: [libc++] Add the "lint" scripts to libcxx-generate-files.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D117357#3258419 <https://reviews.llvm.org/D117357#3258419>, @Quuxplusone wrote:

> In D117357#3258377 <https://reviews.llvm.org/D117357#3258377>, @ldionne wrote:
>
>> If I understand what you are both saying properly, it seems to me that in that case, `libcxx-generate-files` is not the appropriate name.
>>
>> What we want is a third target like `libcxx-precommit-whatever`, which would generate the files and also run the linter, and potentially run `clang-tidy` in the future, etc. I think what's blocking me right now is that linting is not in any way generating something, so `libcxx-generate-files` just seems like the wrong name for it. I'm not opposed to the idea of having a quick way to run "quick linting/generating actions" necessary before sending a review -- that does sound useful.
>
> How about `libcxx-tidy`? except that then Clang will want a `clang-tidy` target. ;)
> What if we keep the nice short tab-completable name `libcxx-lint`, and make `libcxx-lint` also fail if the generated files contain any uncommitted changes (for which of course it'll have to generate them as a side effect)?

I like this! It would basically replace the definition for our current `check-generated-output` CI job inside `run-buildbot`. It could then run the `libcxx-lint` target instead, and that would check generated files as well as other things. I think that makes the most sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117357/new/

https://reviews.llvm.org/D117357