[libcxx-commits] [PATCH] D120087: [libc++] Check clang-tidy version

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/utils/libcxx/test/dsl.py:205
+ at _memoizeExpensiveOperation(lambda c, s: (c.substitutions, c.environment, s))
+def runCommandGetVersion(config, command):
+  with _makeConfigTest(config) as test:
----------------
Instead, I'd rather have something like `commandOutput` that returns the output of the command, and then you can `re.search` on that from `features.py`. I think that's more likely to be useful in the future than `runCommandGetVersion`.


================
Comment at: libcxx/utils/libcxx/test/dsl.py:209
+    if exitCode != 0:
+     return -1
+    return int(re.search('[0-9]+', out).group())
----------------
I think we want to `raise ConfigurationRuntimeError` here (and yes, that means you'll need to handle the error from `features.py`, but I still think it's the right thing to do).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120087/new/

https://reviews.llvm.org/D120087