[libcxx-commits] [PATCH] D120634: [Libcxx] Add <source_location> header.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

+1 to all @philnik's comments. Looks pretty decent otherwise; let's see what buildkite thinks of it!



================
Comment at: libcxx/test/std/language.support/support.srcloc/general.pass.cpp:11-14
+#include <source_location>
+#include "test_macros.h"
+#include <string.h>
+#include <assert.h>
----------------



================
Comment at: libcxx/test/std/language.support/support.srcloc/general.pass.cpp:43
+// and inside a function.
+int main() {
+  auto local =
----------------
By convention (something about freestanding support): `int main(int, char**) {`
and `return 0;` at the end. See any other test file for comparison.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120634/new/

https://reviews.llvm.org/D120634