[libcxx-commits] [PATCH] D120633: [libc++] Better handling for zero-sized types

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

The tests should be in `libcxx/`, since it's an extension, right? Is there a reason you only check with `make_unique`? If you don't use `make_unique` the `UNSUPPORTED: c++11` could be removed from the test.



================
Comment at: libcxx/include/__memory/unique_ptr.h:50-53
-    static_assert(sizeof(_Tp) > 0,
-                  "default_delete can not delete incomplete type");
-    static_assert(!is_void<_Tp>::value,
-                  "default_delete can not delete incomplete type");
----------------
Could you check the compiler diagnostics before and after?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120633/new/

https://reviews.llvm.org/D120633