[libcxx-commits] [PATCH] D120546: [libcxx] [test] Fix dsl.sh.py to work on Windows.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

My understanding is that the `forsurethisisnotanexistinglocale` fix is pretty much orthogonal to the rest of this patch, and is uncontroversial. Feel free to land that one-liner (with explanatory commit message as discussed above).

I think what you've got here now (`replace('\r\n', '\n')` in `_executeScriptInternal`) is better than what you originally proposed. D120623 <https://reviews.llvm.org/D120623> also looks reasonable to me (but affects tests that libc++ doesn't own, so make sure you've pinged some people relevant to those tests). However, I think both of these are going to need more eyeballs than mine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120546/new/

https://reviews.llvm.org/D120546