[libcxx-commits] [PATCH] D106124: [libcxx][modules] protects users from relying on detail headers

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

In D106124#3347379 <https://reviews.llvm.org/D106124#3347379>, @thakis wrote:

> Why is this guarded by `_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER` (instead of, say, `_LIBCPP_BUILDING_LIBRARY`, or a dedicated define)? Seems like a fairly unrelated macro.

No idea. Also, all the .verify.cpp tests are superfluously marked `UNSUPPORTED: gcc-11` (verify tests run on Clang by definition), and `ADDITIONAL_COMPILE_FLAGS: -U_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER` ; both of those lines could go away. In fact, the huge huge majority of these tests could go away, and just roll the checks into `lint_headers.sh.py`; I have some ideas in that area.
But as long as mainline CI isn't actively failing, I think it makes the most sense to just wait for @ldionne to come back from vacation and then see what he wants to do with this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106124/new/

https://reviews.llvm.org/D106124