[libcxx-commits] [PATCH] D106124: [libcxx][modules] protects users from relying on detail headers
Eric Fiselier via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Feb 25 14:47:57 PST 2022
EricWF added a comment.
In D106124#3346349 <https://reviews.llvm.org/D106124#3346349>, @Quuxplusone wrote:
> @EricWF obviously this should wait for @ldionne to return; it hasn't been touched since July 2021, so let's not jump the gun here.
I don't see the need for that.
> Data point: We //do// now have a way to test for the existence of a line in every header, without generating a `.verify.cpp` test for every single detail header: see `libcxx/test/libcxx/lint/lint_headers.sh.py`. However, personally I'd be willing to do that part of the change myself (either Chris could eliminate all the new tests //before// landing, or I could do it myself with a big `git rm` after landing, I don't actually care which).
We want to verify the actual diagnostic.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106124/new/
https://reviews.llvm.org/D106124
More information about the libcxx-commits
mailing list