[libcxx-commits] [PATCH] D114786: [libc++] Remove the ability to use the std::nullptr_t emulation in C++03 mode

[James Nagurne via Phabricator via libcxx-commits]

JamesNagurne added a comment.

Hi Louis,

Our downstream validations have begun failing when downstreaming this change.

C++11 18.2.9 states that nullptr_t is defined as:

  namespace std {
    typedef decltype(nullptr) nullptr_t;
  }

Our conformance test suite ensures this by having the following:

  #include <cstddef>
  nullptr_t ptr = nullptr;

And expects a diagnostic, specifically that nullptr_t is not defined.
This is a change in behavior for the compiler. Was that expected?

Here's an example comparing trunk to a previous version.

https://godbolt.org/z/GjbEh1hqT


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114786/new/

https://reviews.llvm.org/D114786