[libcxx-commits] [PATCH] D120466: [libc++] Granularize <utility> includes

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/vector:311
 #include <typeinfo>
-#include <utility>
 
----------------
Quuxplusone wrote:
> As in the previous PR, please do the removal of these lines in a separate commit (and optionally in a whole separate PR). Because adding `#include <__utility/move.h>` probably can't break anything, and adding `#include <utility>` to some tests can't break anything, but //removing `#include <utility>` from existing headers like `<vector>` and `<typeindex>`// can definitely break users, and if they complain we might want to `git revert` just that one part. So it should be isolated in its own commit.
> 
> Actually, looking at your changes in `<variant>`, it seems like you intended to do what I'm saying here, and this diff just slipped through the cracks? I think what you did in `<variant>`, adding a line `#include <utility> // TODO: Remove this`, is good.
+1
Also please update the release notes in the removal PR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120466/new/

https://reviews.llvm.org/D120466