[libcxx-commits] [PATCH] D120469: [libcxx] [test] Add a 'win32-' prefix to the 'broken-utf8-wchar-ctype' feature

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D120469#3343047 <https://reviews.llvm.org/D120469#3343047>, @Quuxplusone wrote:

> LGTM, thanks!
> I don't know if you want to rush this in, or wait a day or two to see if someone really //objects// to the "win32-" prefix; will leave that to your judgment. In this case, your own ability to imagine objections (and vice versa to know how annoying it would be //not// to land this) will be better than mine. :)

There shouldn’t be any rush, and it didn’t really conflict practically with anything else in my queue, so I can leave it open for some days. Same thing with https://reviews.llvm.org/D120022 which uses the new naming; I can hold off of pushing that one once it’s ok’d too, to get the naming consistent without too much back and forth.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120469/new/

https://reviews.llvm.org/D120469