[libcxx-commits] [PATCH] D119036: [libc++] Fix modules and benchmarks CI builds when incomplete features are disabled

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D119036#3302341 <https://reviews.llvm.org/D119036#3302341>, @ldionne wrote:

> Push/pop min and max in filesystem_helper.h

The change to push/pop those in filesystem_helper.h broke testing any other library than libc++, as the standard headers now require libc++ internal headers (`<__undef_macros>`) and macros (`_LIBCPP_PUSH_MACROS`, `_LIBCPP_POP_MACROS`).

How would you prefer to fix that - reinstate the `-DNOMINMAX` in the testing config, or just use a plain `#undef max` in the test support header? Or spell out the corresponding push/pop directives with compiler conditionals?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119036/new/

https://reviews.llvm.org/D119036