[libcxx-commits] [PATCH] D120022: [libcxx] [test] Fix the put_double, put_long_double tests for clang-cl

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.pass.cpp:17880
+#endif
 }
 
----------------
Quuxplusone wrote:
> Any appetite to transplant these two tests into a separate file that could be `XFAIL: msvc`'ed? You could call it, like, `put_double.hex.pass.cpp`.
I guess that sounds doable, I'll give that a shot.


================
Comment at: libcxx/utils/libcxx/test/features.py:99
+          }
+          """)),
+
----------------
Quuxplusone wrote:
> I missed out on D119930; this approach seems reasonable to me too. But what would you think of giving all these Windows UCRT bugs a common prefix, something like `win32-broken-utf8-wchar-ctype`, `win32-broken-printf-g-precision`, and so on?
> I assume `msvc-broken-...` would have the wrong connotation because this affects both msvc and clang-cl, right? Would `win32-broken-` have better connotations? `msc-ucrt-broken-`??
Sure, adding a `win32-` prefix to the bug feature name sounds good to me. I can make a separate review for changing the existing one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120022/new/

https://reviews.llvm.org/D120022