[libcxx-commits] [PATCH] D119385: Use trivial relocation operations in std::vector, by porting D67524 and part of D61761 to work on top of the changes in D114732.
Devin Jeanpierre via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Feb 23 11:35:49 PST 2022
devin.jeanpierre added a comment.
I finished running a macrobenchmark. The benchmark itself is internal to Google, but I hope it is useful as a data point anyway -- I emulated the wording from the doc on adding trivial_abi to unique_ptr <https://libcxx.llvm.org//DesignDocs/UniquePtrTrivialAbi.html>. And, of course, I want to remain somewhat cagey and say things like "up to", as the actual performance improvement depends on the application, and I only tested one application.
(0.25% is //incredibly// good in my books, I was not expecting this -- talked with some people and they explained that since this is more than just e.g. unique_ptr, and it unlocks optimizations in neighboring code, etc, the number is plausible.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119385/new/
https://reviews.llvm.org/D119385
More information about the libcxx-commits
mailing list