[libcxx-commits] [PATCH] D118179: [SystemZ][z/OS] Localize runtime error messages in libc++

[Muiez Ahmed via Phabricator via libcxx-commits]

muiez marked 4 inline comments as done.
muiez added inline comments.


================
Comment at: libcxxabi/src/abort_message.cpp:8
 //===----------------------------------------------------------------------===//
-
+#include "abort_message.h"
 #include <stdlib.h>
----------------
zibi wrote:
> I might be wrong but I think the use defined headers should be included after the system ones. Can you keep it the original order?
The "abort_message.h" header should be included before the others in this case because we refer to bimodal functions (eg `__fprintf_a`). In particular, abort_message.h includes error_message.h which includes the Bimodal header. This should be included before the other headers (such as stdio.h) to avoid an undeclared identifier error.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118179/new/

https://reviews.llvm.org/D118179