[libcxx-commits] [PATCH] D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS

[Zibi Sarbino via Phabricator via libcxx-commits]

zibi marked an inline comment as done.
zibi added a comment.

In D120348#3338820 <https://reviews.llvm.org/D120348#3338820>, @Quuxplusone wrote:

> Does this mean that D110349 <https://reviews.llvm.org/D110349> and/or D117375 <https://reviews.llvm.org/D117375> could be closed/abandoned at this point?

Yes, they will be closed once this is approved.



================
Comment at: libcxxabi/src/cxa_guard_impl.h:296
+  bool wait(LibcppMutex& mut) { return _VSTD::internal_thread::__libcpp_condvar_wait(&cond, &mut.mutex); }
+  bool broadcast() { return _VSTD::internal_thread::__libcpp_condvar_broadcast(&cond); }
 
----------------
Quuxplusone wrote:
> Do you know a concrete reason that `_VSTD` is needed here, i.e. why wouldn't `std::internal_thread::__libcpp_condvar_broadcast` work here?
No reason, I will change it to `std::internal_thread::`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120348/new/

https://reviews.llvm.org/D120348