[libcxx-commits] [PATCH] D118179: [SystemZ][z/OS] Localize runtime error messages in libc++

[Zibi Sarbino via Phabricator via libcxx-commits]

zibi added a comment.

LGTM with minor suggestions.



================
Comment at: libcxxabi/src/abort_message.cpp:8
 //===----------------------------------------------------------------------===//
-
+#include "abort_message.h"
 #include <stdlib.h>
----------------
I might be wrong but I think the use defined headers should be included after the system ones. Can you keep it the original order?


================
Comment at: libcxxabi/src/abort_message.h:12
 
+#include <include/error_message.h>
 #include "cxxabi.h"
----------------
This will make consistent by including this header as user define one and move it down after `cxxabi.h as being done in other locations.


================
Comment at: libcxxabi/src/cxa_guard_impl.h:48
 #include "include/atomic_support.h" // from libc++
+#include <include/error_message.h>
 #if defined(__has_include)
----------------
same as above


================
Comment at: libcxxabi/src/cxa_virtual.cpp:9
 
+#include <include/error_message.h>
 #include "cxxabi.h"
----------------
same as above


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118179/new/

https://reviews.llvm.org/D118179