[libcxx-commits] [PATCH] D120090: [libcxx] [test] Fix the thousands_sep expectation for fr_FR locales on Windows

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

LGTM%comment!



================
Comment at: libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp:55-58
 // GLIBC 2.27 and newer use U2027 (narrow non-breaking space) as a thousands sep.
 // this function converts the spaces in string inputs to that character if need
 // be. FreeBSD's locale data also uses U2027 since 2018.
+// Windows uses U00A0.
----------------
The original commenter seems to have mixed up U+202F NARROW NO-BREAK SPACE with U+2027 HYPHENATION POINT. I don't imagine that any platform would use U+2027 HYPHENATION POINT as its thousands separator.


================
Comment at: libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_fr_FR.pass.cpp:55-58
 // GLIBC 2.27 and newer use U2027 (narrow non-breaking space) as a thousands sep.
 // this function converts the spaces in string inputs to that character if need
 // be. FreeBSD's locale data also uses U2027 since 2018.
+// Windows uses U00A0.
----------------
Same deal with this comment, please.


================
Comment at: libcxx/test/std/localization/locale.categories/category.monetary/locale.moneypunct.byname/thousands_sep.pass.cpp:140
     // The below tests work around GLIBC's use of U00A0 as mon_thousands_sep
     // and U002E as mon_decimal_point.
     // TODO: Fix thousands_sep for 'char'.
----------------
Pre-existing: I find it unlikely that we have to "work around" the use of U+002E FULL STOP as a decimal point character. ;) That's... normal. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120090/new/

https://reviews.llvm.org/D120090