[libcxx-commits] [PATCH] D119972: [demangler] Improve buffer hysteresis

[Chuanqi Xu via Phabricator via libcxx-commits]

ChuanqiXu added a comment.

In D119972#3331718 <https://reviews.llvm.org/D119972#3331718>, @urnathan wrote:

> In D119972#3331375 <https://reviews.llvm.org/D119972#3331375>, @ChuanqiXu wrote:
>
>> Oh, the test looks not straight forward. I am confused at the first sight. And I figure it out after thinking for a while. I could understand it since I have the revision background. I guess other people reading the test might be confused. I have two suggestion:
>>
>> 1. Add a debug counter wrapped by `#ifndef NDEBUG` and a corresponding test wrapped by `#ifndef NDEBUG`. This is friendly for reader to read.
>> 2. Or at least create another test with new name `Reallocation` and a corresponding comment.
>
> I think you're making this far too complicated.

I don't think so. I think the reader who reads the test would be confused really. And it wouldn't be complicated. All we need to do is to add a new `TEST` and a more detailed comment. I think it wouldn't take too many lines.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119972/new/

https://reviews.llvm.org/D119972