[libcxx-commits] [PATCH] D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D118930#3332884 <https://reviews.llvm.org/D118930#3332884>, @NancyWang2222 wrote:

> In D118930#3332708 <https://reviews.llvm.org/D118930#3332708>, @philnik wrote:
>
>> There should also be a test changed somewhere in `libcxx/test/std/localization`, or is this only part of the fix?
>
> Thanks for providing information, can you provide more detail about what change need for libcxx/test/localization, the patch will fix bunch of Assert d1==d2 issues in std/numerics/rand/rand.dis/rand.dist.bern/ on z/OS related to float point value.

I would have expected test failures in `locale.categories/category.numeric/facet.num.get.members/get_float.pass.cpp`, since this patch changes behavior of `std::num_get` on AIX IIUC. So either I'm not understanding something here or there are some test cases missing. Wait there are also no `// XFAIL: AIX` in `std/numerics/rand.dis/rand.dis.bern/`. Are these tests currently disabled on AIX somehow?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118930/new/

https://reviews.llvm.org/D118930