[libcxx-commits] [PATCH] D120135: [libc++] Overhaul std::quoted; fix its relationship to character traits.

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 18 09:26:08 PST 2022


philnik added a comment.

If you have multiple commits for this mess it would be nice to have multiple PRs.



================
Comment at: libcxx/include/__filesystem/path.h:971
     basic_string<_CharT, _Traits> __tmp;
-    __is >> __quoted(__tmp);
+    __is >> _VSTD::__quoted(__tmp);
     __p = __tmp;
----------------



================
Comment at: libcxx/include/iomanip:521
+__quoted_output(basic_ostream<_CharT, _Traits>& __os,
+                const _CharT *__first, const _CharT *__last, _CharT __delim, _CharT __escape)
 {
----------------



================
Comment at: libcxx/include/iomanip:525
     __str.push_back(__delim);
-    for ( ; __first != __last; ++ __first )
+    for ( ; __first != __last; ++__first)
     {
----------------



================
Comment at: libcxx/include/iomanip:579
+    _LIBCPP_HIDE_FROM_ABI
+    explicit __quoted_output_proxy(const _CharT *__f, const _CharT *__l, _CharT __d, _CharT __e)
+        : __first_(__f), __last_(__l), __delim_(__d), __escape_(__e) {}
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120135/new/

https://reviews.llvm.org/D120135



More information about the libcxx-commits mailing list