[libcxx-commits] [PATCH] D120139: [libc++] [ranges] Permit std::mergeable and std::sortable with HAS_NO_INCOMPLETE_RANGES

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, var-const, Mordante, libc++.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

This follows the general direction of D118736 <https://reviews.llvm.org/D118736> that `_LIBCPP_HAS_NO_INCOMPLETE_RANGES` does *not* guard anything outside of the `std::ranges::` namespace itself. This means we must permit `ranges::less` etc. in no-ranges mode; that seems fine to me.

I believe this doesn't need to be merged to release/14.x, unless @ldionne you want to //also// merge eea3d90af181fdb66e583af53401e80ddfcc8cd1 <https://reviews.llvm.org/rGeea3d90af181fdb66e583af53401e80ddfcc8cd1> and 8e979460bb27610d574733ca5b75afae0cdfb3c9 <https://reviews.llvm.org/rG8e979460bb27610d574733ca5b75afae0cdfb3c9> to release/14.x? (Again, the only logic to that would be so that we could brag that a sensible, non-arbitrary subset was implemented in libc++14.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D120139

Files:
  libcxx/include/__functional/ranges_operations.h
  libcxx/include/__iterator/mergeable.h
  libcxx/include/__iterator/sortable.h
  libcxx/test/std/iterators/iterator.requirements/alg.req.mergeable/mergeable.compile.pass.cpp
  libcxx/test/std/iterators/iterator.requirements/alg.req.mergeable/mergeable.subsumption.compile.pass.cpp
  libcxx/test/std/iterators/iterator.requirements/alg.req.sortable/sortable.compile.pass.cpp
  libcxx/test/std/iterators/iterator.requirements/alg.req.sortable/sortable.subsumption.compile.pass.cpp
  libcxx/test/std/utilities/function.objects/range.cmp/equal_to.pass.cpp
  libcxx/test/std/utilities/function.objects/range.cmp/greater.pass.cpp
  libcxx/test/std/utilities/function.objects/range.cmp/greater_equal.pass.cpp
  libcxx/test/std/utilities/function.objects/range.cmp/less.pass.cpp
  libcxx/test/std/utilities/function.objects/range.cmp/less_equal.pass.cpp
  libcxx/test/std/utilities/function.objects/range.cmp/not_equal_to.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120139.409953.patch
Type: text/x-patch
Size: 7645 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220218/1bd12bb1/attachment.bin>