[libcxx-commits] [PATCH] D119972: [demangler] Improve buffer hysteresis

Chuanqi Xu via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 17 22:03:27 PST 2022


ChuanqiXu added a comment.

Oh, the test looks not straight forward. I am confused at the first sight. And I figure it out after thinking for a while. I could understand it since I have the revision background. I guess other people reading the test might be confused. I have two suggestion:

1. Add a debug counter wrapped by `#ifndef NDEBUG` and a corresponding test wrapped by `#ifndef NDEBUG`. This is friendly for reader to read.
2. Or at least create another test with new name `Reallocation` and a corresponding comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119972/new/

https://reviews.llvm.org/D119972



More information about the libcxx-commits mailing list