[libcxx-commits] [PATCH] D120091: [libcxx] [test] Fix moneypunct grouping tests on Windows

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/localization/locale.categories/category.monetary/locale.moneypunct.byname/grouping.pass.cpp:93
+#else
+    std::string us_grouping = "\3\3";
+#endif
----------------
https://en.cppreference.com/w/cpp/locale/numpunct/grouping
Geesh, this stuff is ridiculous. I buy how `\3` and `\3\3` are equivalent; but then my next question is, why does the existing code (on non-Windows) return `\3\3`? Is that due to something at the OS level that's out of our control, or is there some way that libc++ could fix it to sanely return a simple `\3` like cppreference says it should?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120091/new/

https://reviews.llvm.org/D120091