[libcxx-commits] [PATCH] D119539: [libcxx] [cmake] Fix linking to installed libc++abi in runtimes build

[Michał Górny via Phabricator via libcxx-commits]

mgorny added inline comments.


================
Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:110
 
-  if(LIBCXX_STANDALONE_BUILD AND NOT (LIBCXX_CXX_ABI_INTREE OR HAVE_LIBCXXABI))
-    set(shared c++abi)
-    set(static c++abi)
-  else()
+  if(TARGET cxxabi_shared OR TARGET cxxabi_static)
     set(shared cxxabi_shared)
----------------
ldionne wrote:
> mgorny wrote:
> > ldionne wrote:
> > > I think this doesn't work because `cxxabi_shared` and `cxxabi_static` might not be known by the time we get here. What is the behavior you'd like to see here? Are you attempting to link against the system `libc++abi.so`?
> > Yes, exactly that.
> I think what we want instead is to have another choice for the ABI library, something like `system-libcxxabi`. When that ABI library is selected, we'd add `-lc++abi` and the right include path.
Ok, I'll update the patch in a few hours.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119539/new/

https://reviews.llvm.org/D119539