[libcxx-commits] [PATCH] D119982: [libc++][AIX] Add AIX error message as expected output

[David Tenty via Phabricator via libcxx-commits]

daltenty accepted this revision.
daltenty added a comment.

LGTM, just copying the longer rational why the message is expected on AIX.

Looks like it's looking for the fallback message text from do_strerror_r.  Which is returned if handle_strerror_r_return generates no message, which it would if strerror_r returned error EINVAL.

According to POSIX for strerror_r:

  These functions may fail if:
  
  [EINVAL]
  [CX] [Option Start] The value of errnum is neither a valid error number nor zero. [Option End]

That's a may, so I guess libc is ok to return it's own unknown error message string for unknown error codes which it does on AIX.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119982/new/

https://reviews.llvm.org/D119982