[libcxx-commits] [PATCH] D120064: Fix EBO on std::optional and std::variant when targeting the MSVC ABI

Jan Wilken Dörrie via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 17 08:16:39 PST 2022


jdoerrie added a comment.

Hi both, PTAL. I was surprised to find out that both `std::variant<int>` and `std::optional<int>` have a sizeof 12 in my environment, this is my attempt to fix it. Please do let me know if there are other places I need to change, or how I would write a test to prevent future regressions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120064/new/

https://reviews.llvm.org/D120064



More information about the libcxx-commits mailing list