[libcxx-commits] [PATCH] D119628: [libc++] Don't return alloc_size - 1 in __recommend to add 1 when allocating

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

> ping

It seems like the CI doesn't like this at all. I assumed there's a missing +1 (or an extra +1) somewhere, so I haven't looked at it at all — waiting for the CI to be green before we think about whether this is a good idea or not.

I do think you should eliminate the `_VSTD` and `HIDE_FROM_ABI` diffs from this PR; this is subtle enough that fewer distractions will be better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119628/new/

https://reviews.llvm.org/D119628