[libcxx-commits] [PATCH] D119264: [libc++] Rename *SAFE_STATIC to *CONSTINIT, and normalize its uses.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

In D119264#3329344 <https://reviews.llvm.org/D119264#3329344>, @thakis wrote:

> If you do want to address it, the easiest fix is probably to just use `constinit` instead of `_LIBCPP_CONSTINIT` in libc++abi (and disable the tests that include the internal header, or make them build with -std=c++20 too, or something).

If we want to address it, I'd suggest we could add

  #ifndef _LIBCPP_CONSTINIT
  #define _LIBCPP_CONSTINIT constinit
  #endif

somewhere near the top of the offending files.

But I'll defer to @ldionne as to whether we want to address this at all; I have no opinion myself, and it sounds like you found an okay workaround. @ldionne?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119264/new/

https://reviews.llvm.org/D119264