[libcxx-commits] [PATCH] D119264: [libc++] Rename *SAFE_STATIC to *CONSTINIT, and normalize its uses.

[Nico Weber via Phabricator via libcxx-commits]

thakis added a comment.

Hi, this is causing us some trouble: We build with a very new libc++abi (our project autoupdates to the latest version of libc++abi every time a change lands), but an old-ish (1 year maybe) libc++ (our libc++ doesn't autoupdate yet – we're working on that part).

So our libc++ header files don't have `_LIBCPP_CONSTINIT` yet (it's added in this change here), but libc++abi requires it now.

Even if our libc++ would autoupdate, we probably wouldn't be able to auto-import this change automatically since libc++ and libc++abi would still autoupdate separately from each other.

If this is something you want to address at all is up to you – our setup is admittedly weird, but libc++ and libc++abi _are_ separate projects, and our setup has been working fine for the last few years.

If you do want to address it, the easiest fix is probably to just use `constinit` instead of `_LIBCPP_CONSTINIT` in libc++abi (and disable the tests that include the internal header, or make them build with -std=c++20 too, or something).

Thanks for your consideration.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119264/new/

https://reviews.llvm.org/D119264