[libcxx-commits] [PATCH] D119948: [libcxx][CI] Set Arm triples to match native clang build's default

[David Spickett via Phabricator via libcxx-commits]

DavidSpickett added inline comments.


================
Comment at: libcxx/test/std/language.support/cmp/cmp.alg/strong_order_long_double.verify.cpp:13
 // The following platforms have sizeof(long double) == sizeof(double), so this test doesn't apply to them.
-// UNSUPPORTED: target={{arm64|armv8|armv7|armv7m|powerpc|powerpc64}}-{{.+}}
+// UNSUPPORTED: target={{arm64|armv(7|8)(l|m)?|powerpc|powerpc64}}-{{.+}}
 // UNSUPPORTED: target=x86_64-pc-windows-{{.+}}
----------------
rovka wrote:
> Should this also catch aarch64?
Surprised me too but no. arm64 darwin they have the same size but aarch64 Linux follows the AAPCS64 standard where they are different. (I assume BSD's do this too)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119948/new/

https://reviews.llvm.org/D119948