[libcxx-commits] [PATCH] D120022: [libcxx] [test] Fix the put_double, put_long_double tests for clang-cl

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added reviewers: Mordante, Quuxplusone.
Herald added a subscriber: arichardson.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

These tests are hit hard by a bug that is fixed in a newer version
of UCRT. Add a test for the specific bug, and XFAIL the tests if
that bug is present (as it is in CI).

With that bug fixed, there's still one aspect in printf formatting that
differs, that requires ifdeffing out a couple parts of the test (hex
float formatting). Based on reading the C standard for printf formatting,
it seems like this isn't necessarily a proper bug in printf, but just a
case of differing optional behaviour.

(Layering this on top of D119930 <https://reviews.llvm.org/D119930>, to reuse the `programSucceeds`
function added there.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D120022

Files:
  libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
  libcxx/utils/libcxx/test/features.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120022.409536.patch
Type: text/x-patch
Size: 5848 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220217/b0a76a52/attachment.bin>