[libcxx-commits] [PATCH] D120010: [libcxx][test] Compilers emulating MSVC do not support int128

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

This change probably is good in itself, but the situation of `__int128_t` in clang-cl environments is actually more complex than that.

Clang-cl actually does support code generation for the `__int128_t` type, but it doesn't have access to the division helper routines provided by compiler-rt builtins normally.

Regarding libc++ (which is only tangential, as I take it your commit is about testing STL with libc++'s testsuite) - in https://reviews.llvm.org/D91139 I suggested explicitly disabling use of `__int128_t` in libc++ due to this (as it can't be used as-is), but it was decided the way forward was to provide those helpers, somehow, e.g. the comment https://reviews.llvm.org/D91139#2429595. But there hasn't been any other specific progress on that front since, and the clang-cl CI configurations build with `_LIBCPP_HAS_NO_INT128` explicitly defined: https://github.com/llvm/llvm-project/blob/d271fc04d5b97b12e6b797c6067d3c96a8d7470e/libcxx/utils/ci/run-buildbot#L99-L113


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120010/new/

https://reviews.llvm.org/D120010